Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and update copyright headers #1421

Closed
fweik opened this issue Sep 20, 2017 · 6 comments
Closed

Check and update copyright headers #1421

fweik opened this issue Sep 20, 2017 · 6 comments
Assignees
Milestone

Comments

@fweik
Copy link
Contributor

fweik commented Sep 20, 2017

No description provided.

@fweik fweik added the Todo label Sep 20, 2017
@fweik fweik added this to the Espresso 4.0 milestone Sep 20, 2017
@fweik fweik self-assigned this Sep 20, 2017
@hmenke
Copy link
Member

hmenke commented Sep 20, 2017

Please convert this

/*
  Copyright (C) 2010,2011,2012,2013,2014,2015,2016 The ESPResSo project
  Copyright (C) 2002,2003,2004,2005,2006,2007,2008,2009,2010
    Max-Planck-Institute for Polymer Research, Theory Group

into this

/*
  Copyright (C) 2010-2017 The ESPResSo project
  Copyright (C) 2002-2010 Max-Planck-Institute for Polymer Research, Theory Group

Ideally one could do something like

/* License GPLv3 <http://www.gnu.org/licenses/> */

Copyright headers only need to be updated when the file is edited. If the file was last touched in 2016, then the header must not extend the copyright to 2017.

This is probably worth reading in that regard: https://softwareengineering.stackexchange.com/questions/125836/do-you-have-to-include-a-license-notice-with-every-source-file

@mkuron
Copy link
Member

mkuron commented Dec 13, 2017

The license notice we currently have is common practice in GPLv3 projects (so that the license and warranty disclaimer remain intact even when a file is moved out of the project), while the copyright notice is not. Under German law, you do not need to explicitly assert your copyright to have copyright, so we could just delete the notice entirely without changing anything.
Also, "The ESPResSo project" is not a legal entity, so that line is kind of pointless anyway. The true copyright owners are the individual contributors (and usually their institutions have some kind of implied license to it). Since you can't transfer copyright under German law, the MPIP is probably not the true copyright holder before 2010 either.

@KaiSzuttor
Copy link
Member

What is the decision here?

@pdebuyl
Copy link
Contributor

pdebuyl commented Apr 24, 2018

Some Python projects have something along the lines of

/*
  Copyright (C) 2002-2017 The ESPResSo project

or

/*
  Copyright (C) 2002-2017 The ESPResSo developers

with the precise meaning in a file AUTHORS (that espresso has already anyway) or in the changelog (numpy for instance).

I don't know the intent here, or the importance of keeping explicitly the MPI Polymer name.

@fweik
Copy link
Contributor Author

fweik commented Aug 29, 2018

I suppose this was fixed by #2198?

@mkuron
Copy link
Member

mkuron commented Aug 29, 2018

Yes, please close this ticket.

@fweik fweik closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants