Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket python package in the windows offline installer #206

Open
kolipakakondal opened this issue Oct 30, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@kolipakakondal
Copy link
Collaborator

Please include the WebSocket Python package in the Windows offline installer, as it will be required by the serial monitor; otherwise, it will fail if someone working without internet connection.

This was handled in the IDE during the tools installation process, however but that requires internet again!

@kolipakakondal kolipakakondal added the enhancement New feature or request label Oct 30, 2023
@dobairoland
Copy link

One way to address this is to add a new IDE "feature" to ESP-IDF. It would be a new file in https://github.com/espressif/esp-idf/tree/master/tools/requirements where you could place all additional IDE requirements and eliminate to handle this at the IDE plugin side. Then the installer could just run the following (if IDE support was selected):

idf_tools.py install --features=core,ide

For CLI-only environments these packages won't be installed.

This would also ensure that the packages are tested to be compatible with other ESP-IDF requirements and issues like espressif/vscode-esp-idf-extension#1054 would not happen.

@kolipakakondal
Copy link
Collaborator Author

One way to address this is to add a new IDE "feature" to ESP-IDF. It would be a new file in https://github.com/espressif/esp-idf/tree/master/tools/requirements where you could place all additional IDE requirements and eliminate to handle this at the IDE plugin side. Then the installer could just run the following (if IDE support was selected):

idf_tools.py install --features=core,ide

For CLI-only environments these packages won't be installed.

This would also ensure that the packages are tested to be compatible with other ESP-IDF requirements and issues like espressif/vscode-esp-idf-extension#1054 would not happen.

That's good advice for managing the extra dependencies required by IDEs. I somehow lost this thread. We can create a requirements.ide.txt file and include websocket-client as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants