-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ADC button tied to GND ignored (AEGHB-691) #372
Conversation
👋 Hello demianzenkov, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@demianzenkov Thanks for your contribution. It is recommended to release a new bugfix package |
@demianzenkov LGTM! |
sha=c089dd8b1deae5ff66919dec581f1f5cf10d0708 |
Bug: if there is an ADC button in the group which is tied to GND the read value is ignored and callbacks do not work. SW2 on attached screenshot cannot be enabled.
Reason:
adc_button_config.min = 0
is not included in the condition.Fix: include
adc_button_config.min = 0
inbutton_adc_get_key_level
method.