Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ADC button tied to GND ignored (AEGHB-691) #372

Closed
wants to merge 2 commits into from
Closed

fix: ADC button tied to GND ignored (AEGHB-691) #372

wants to merge 2 commits into from

Conversation

demianzenkov
Copy link
Contributor

@demianzenkov demianzenkov commented Jun 16, 2024

Bug: if there is an ADC button in the group which is tied to GND the read value is ignored and callbacks do not work. SW2 on attached screenshot cannot be enabled.
Reason: adc_button_config.min = 0 is not included in the condition.
Fix: include adc_button_config.min = 0 in button_adc_get_key_level method.
Screenshot 2024-06-17 at 01 15 18

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jun 16, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello demianzenkov, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c089dd8

@github-actions github-actions bot changed the title fix: ADC button tied to GND ignored fix: ADC button tied to GND ignored (AEGHB-691) Jun 16, 2024
@leeebo leeebo added the button label Jun 17, 2024
@leeebo
Copy link
Collaborator

leeebo commented Jun 17, 2024

@demianzenkov Thanks for your contribution. It is recommended to release a new bugfix package 3.2.0 -> 3.2.1

  1. change the version number in https://github.com/espressif/esp-iot-solution/blob/master/components/button/idf_component.yml#L1
  2. update changelog https://github.com/espressif/esp-iot-solution/blob/master/components/button/CHANGELOG.md

@leeebo leeebo self-requested a review June 17, 2024 07:42
@leeebo
Copy link
Collaborator

leeebo commented Jun 17, 2024

@demianzenkov LGTM!

@leeebo
Copy link
Collaborator

leeebo commented Jun 17, 2024

sha=c089dd8b1deae5ff66919dec581f1f5cf10d0708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants