Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_http_client to support chunked request (IDFGH-4401) #6234

Closed
galah92 opened this issue Dec 9, 2020 · 9 comments
Closed

esp_http_client to support chunked request (IDFGH-4401) #6234

galah92 opened this issue Dec 9, 2020 · 9 comments
Labels
Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@galah92
Copy link

galah92 commented Dec 9, 2020

Is your feature request related to a problem? Please describe.
I'm trying to steam data over a single HTTP request using chunked requests (PUT request).

Describe the solution you'd like
Current HTTP-client-API has esp_http_client_open() which takes the total size of the request. This prevents from defining a chunked requests and esp_http_client_write()ing as much as I want.

@galah92 galah92 added the Type: Feature Request Feature request for IDF label Dec 9, 2020
@github-actions github-actions bot changed the title esp_http_client to support chunked request esp_http_client to support chunked request (IDFGH-4401) Dec 9, 2020
@Alvin1Zhang
Copy link
Collaborator

Thanks for raising this feature request.

@galah92
Copy link
Author

galah92 commented Jan 10, 2021

Just to elaborate - it seems that using a negative write_len will add chunked "Transfer-Encoding" header, but will also override the method to be POST. My use-case is for chunked requests with PUT method.

@shubhamkulkarni97
Copy link
Contributor

Hi @galah92,

Sorry for slow turnaround. I got the issue where HTTP method gets overwritten to POST while sending chunked request.

Can you try applying patch attached below and check if it works for your use case?

0001-esp_http_client-Set-HTTP-method-to-POST-only-if-meth.patch.zip

@galah92
Copy link
Author

galah92 commented Mar 26, 2021

Hi @shubhamkulkarni97. The patch is working, thanks.
Can this be merged to v4.3?

@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally and removed Status: In Progress Work is in progress labels Mar 30, 2021
@shubhamkulkarni97
Copy link
Contributor

@galah92 The change is merged internally. However, this will not be a part of v4.3 as it is a breaking change

@galah92
Copy link
Author

galah92 commented Jun 28, 2021

@shubhamkulkarni97 @Alvin1Zhang will this be included as part of v4.4? Is there an ETA for that?

@galah92
Copy link
Author

galah92 commented Jul 25, 2021

@shubhamkulkarni97 @Alvin1Zhang will this be included as part of v4.4? Is there an ETA for that?

Any update? This is long awaited bugfix. Thanks

@galah92
Copy link
Author

galah92 commented Aug 17, 2021

@shubhamkulkarni97 @Alvin1Zhang bumping it again. This bugfix is of great importance for us, thank you.

@shubhamkulkarni97
Copy link
Contributor

Hi @galah92,

This fix will be a part of v4.4 release. We are aiming to release IDF v4.4 by end of 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

4 participants