Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"erase_otadata" and "read_otadata" targets don't honor ESPPORT (IDFGH-3289) #5280

Closed
jimparis opened this issue May 12, 2020 · 1 comment
Closed

Comments

@jimparis
Copy link

esp-idf version v4.0-386-gb0f053d82dc4

Related to #3135, the erase_otadata and read_otadata targets still don't always use the same port as the rest of the flashing commands, because they don't honor ESPPORT and ESPBAUD.

The documentation for e.g. using idf.py says "The environment variables ESPPORT and ESPBAUD can be used to set default values for the -p and -b options" but the otadata commands only use what's set in the sdkconfig.

@github-actions github-actions bot changed the title "erase_otadata" and "read_otadata" targets don't honor ESPPORT "erase_otadata" and "read_otadata" targets don't honor ESPPORT (IDFGH-3289) May 12, 2020
@jimparis
Copy link
Author

I'm working on converting my project to CMake and it seems like the same problem is there -- esp_idf/components/app_update/CMakeLists.txt passes CONFIG_ESPTOOLPY_BEFORE and CONFIG_ESPTOOLPY_AFTER to otatool.py, but doesn't pass the port at all, and doesn't honor ESPPORT, ESPBAUD, etc.

My guess is this also affects commands like idf.py partition_table-flash but I haven't dug in enough to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant