Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing spurious \n in ESP_LOG calls? (IDFGH-10197) #11465

Closed
3 tasks done
mickeyl opened this issue May 22, 2023 · 2 comments
Closed
3 tasks done

Removing spurious \n in ESP_LOG calls? (IDFGH-10197) #11465

mickeyl opened this issue May 22, 2023 · 2 comments
Assignees
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally

Comments

@mickeyl
Copy link
Contributor

mickeyl commented May 22, 2023

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

I noticed some of the components calling ESP_LOGx with '\n' as the last character, e.g.:

./bt/controller/esp32c3/bt.c:    ESP_LOGI(BT_LOG_TAG, "Bluetooth MAC: %02x:%02x:%02x:%02x:%02x:%02x\n",

This leads to unwanted empty lines in the log. My guess is that they have been (auto-)converted from printf without adjusting the line ending. Would you accept a pull request that removes these additional line feed characters?

@espressif-bot espressif-bot added the Status: Opened Issue is new label May 22, 2023
@github-actions github-actions bot changed the title Removing spurious \n in ESP_LOG calls? Removing spurious \n in ESP_LOG calls? (IDFGH-10197) May 22, 2023
@KonstantinKondrashov
Copy link
Collaborator

Hi @mickeyl!
Thanks for noticing that. I will update it.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Jun 8, 2023
@kriegste
Copy link

kriegste commented Jun 8, 2023

I remember, a while ago I enabled lwip debugging and there were a lot of empty lines in the log, too.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

4 participants