Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable non-blocking socket mode in coreMQTT transport (CA-329) #214

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

paulbartell
Copy link
Contributor

@paulbartell paulbartell commented Jan 31, 2024

Improve mqtt performance by using a non-blocking socket to connect coreMQTT to the MQTT broker.

@github-actions github-actions bot changed the title Enable non-blocking socket mode in coreMQTT transport Enable non-blocking socket mode in coreMQTT transport (CA-329) Jan 31, 2024
@paulbartell paulbartell force-pushed the non-blocking-mqtt-transport branch 3 times, most recently from f9a7ba1 to b03ec96 Compare January 31, 2024 21:44
@txf-
Copy link

txf- commented Feb 5, 2024

I should point out that building this I'm getting:

error: 'lBytesRead' may be used uninitialized [-Werror=maybe-uninitialized]

in espTlsTransportRecv

@txf-
Copy link

txf- commented Feb 5, 2024

I'll put this in a separate comment. I tried this solution and was updating a shadow document. However sometimes it would sends empty messages. I tried increasing xTimeout value to 10000 and that reduces the number of empty updates.

edit: never mind, my previous solution also demonstrates this problem.

@avsheth avsheth merged commit 970df79 into espressif:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants