Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing ESP-IDF LEDC fading functions #7136

Closed
1 task done
davorvr opened this issue Aug 16, 2022 · 3 comments
Closed
1 task done

Implementing ESP-IDF LEDC fading functions #7136

davorvr opened this issue Aug 16, 2022 · 3 comments
Assignees
@P-R-O-C-H-Y
Labels
Status: Solved Type: Feature request Feature request for Arduino ESP32
Milestone
3.0.0

Comments

@davorvr
Copy link

davorvr commented Aug 16, 2022 •
edited
Loading

Related area

LEDC, PWM

Hardware specification

ESP32

Is your feature request related to a problem?

Aside from LED fading, it would be useful for adjusting servos more slowly.

Describe the solution you'd like

I would like esp32-hal-ledc.c to also include functions to wrap the existing fading functionality present in ESP-IDF's ledc.c driver

Describe alternatives you've considered

This can be done with a for loop using a specified delay, as in the LEDCSoftwareFade.ino example, but since this functionality exists at a hardware level, implementation of this would be nice, especially since it can also work in a non-blocking manner.

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.
@davorvr davorvr added the Type: Feature request Feature request for Arduino ESP32 label Aug 16, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 17, 2022
@VojtechBartoska VojtechBartoska added this to the 2.1.0 milestone Aug 17, 2022
@davorvr
Copy link
Author

davorvr commented Aug 17, 2022

Thanks guys, looking forward to 2.1.0! 😄

@VojtechBartoska VojtechBartoska added the Status: Needs investigation We need to do some research before taking next steps on this issue label Aug 18, 2022
@VojtechBartoska
Copy link
Contributor

Hello @davorvr, yeah, we would like to implement this feature in the next major milestone 2.1.0.

@VojtechBartoska VojtechBartoska modified the milestones: 2.0.6, 3.0.0 Sep 21, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this issue Jun 20, 2023
Merged
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: To be implemented Selected for Development and removed Status: Needs investigation We need to do some research before taking next steps on this issue labels Jun 20, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Jun 20, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Solved and removed Status: To be implemented Selected for Development labels Aug 30, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y moved this from In Review to Done in Arduino ESP32 Core Project Roadmap Aug 30, 2023
@P-R-O-C-H-Y
Copy link
Member

Closing this as Fade implementation PR #8338 was already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Solved Type: Feature request Feature request for Arduino ESP32
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@davorvr @VojtechBartoska @P-R-O-C-H-Y