WiFiClientSecure::write only sends the first 16KB

[marcelstoer]

Description:

Shouldn't WiFiClientSecure::write send the whole buffer even beyond SSL fragment length? Currently it only writes up to mbedTLS maximum fragment length which is 16KB by default.

According to ARM mbed TLS mbedtls_ssl_write has the following limitation

If the requested length is greater than the maximum fragment length (either the built-in limit or the one set or negotiated with the peer), then:

• with TLS, less bytes than requested are written.

It appears that mbedtls_ssl_write is only called once at https://github.com/espressif/arduino-esp32/blob/master/libraries/WiFiClientSecure/src/ssl_client.cpp#L280

Sketch

While the (simplified) workaround below works ok it does feel like such a use case should be handled by WiFiClientSecure internally. Opinions?

size_t sent = 0; 
size_t remaining = fileSize; 
size_t offset = 0;

while (true) {
  sent = client->write(buffer + offset, remaining);
  remaining = remaining - sent;
  offset += sent;
  if (remaining <= 0 || sent <= 0) {
    break;
  }
}

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[marcelstoer]

@me-no-dev according to the commit history you might be familiar with the subject?

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[marcelstoer]

@me-no-dev what can I do to get some feedback from a developer to find out if my expectations are justified or not?

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[me-no-dev]

This should definitelly not be the case and I will put it on my list of things to check. Doing such while loops in FreeRTOS might not be a good idea, but I need to have a better look at what goes underneath to know if this can do or not.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[marcelstoer]

"Hey bot, shut up. The grown-ups are talking." Not frequently but they do 😜

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[marcelstoer]

nudge

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[atanisoft]

@marcelstoer perhaps submit a PR with your proposal?

[marcelstoer]

Re: PR; Normally not an issue but I'm not familiar with the inner workings of the affected class(es) to make a meaningful proposal.

Besides @me-no-dev stated that

Doing such while loops in FreeRTOS might not be a good idea

This confirms my initial suspicion that there must be a better solution.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[marcelstoer]

This should definitelly not be the case and I will put it on my list of things to check.

@me-no-dev is it still there?

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[stale]

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

[stale]

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

[everslick]

hehe, I feel your pain. I had the pretty same experience in #2494