From 0a8c586953327af6d38280ca10c612a82b4d1be7 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 31 Aug 2024 09:19:02 -0700 Subject: [PATCH] fix(boards): Remove port property assoc. for non-unique VID/PID pairs The Arduino boards platform framework allows properties of a port to be associated with a board definition. The Arduino development software will identify a port having the associated properties as that board. This should only be done for properties that are unique to the ports produced by that board model. In cases where a board model does not produce a port with properties unique to that model, it is irresponsible to associate those properties with the board definition as this will cause other models to be inappropriately identified. The authors of these board definitions associated them with non-unique USB VID/PID pairs so those associations must be removed. The 303a:1001 VID/PID pair is of the hardware CDC serial port of the native USB ESP32 chips. The others are stock VID/PID pairs of general purpose USB to serial bridge chips that are used on many different board models. --- boards.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/boards.txt b/boards.txt index 6ac1a2cae20..76750f2ba5d 100644 --- a/boards.txt +++ b/boards.txt @@ -4507,8 +4507,6 @@ S_ODI_Ultra.menu.EraseFlash.all.upload.erase_cmd=-e ############################################################## lilygo_t_display.name=LilyGo T-Display -lilygo_t_display.vid.0=0x1a86 -lilygo_t_display.pid.0=0x55d4 lilygo_t_display.upload.tool=esptool_py lilygo_t_display.upload.tool.default=esptool_py @@ -27574,8 +27572,6 @@ fm-devkit.menu.EraseFlash.all.upload.erase_cmd=-e ### Fri3d Badge 2024 (ESP32-S3-WROOM-1) fri3d_2024_esp32s3.name=Fri3d Badge 2024 (ESP32-S3-WROOM-1) -fri3d_2024_esp32s3.vid.0=0x303a -fri3d_2024_esp32s3.pid.0=0x1001 fri3d_2024_esp32s3.bootloader.tool=esptool_py fri3d_2024_esp32s3.bootloader.tool.default=esptool_py @@ -39913,8 +39909,6 @@ waveshare_esp32_s3_lcd_169.menu.EraseFlash.all.upload.erase_cmd=-e ############################################################## waveshare_esp32s3_touch_lcd_128.name=Waveshare ESP32S3 Touch LCD 128 -waveshare_esp32s3_touch_lcd_128.vid.0=0x1a86 -waveshare_esp32s3_touch_lcd_128.pid.0=0x55d3 waveshare_esp32s3_touch_lcd_128.upload.tool=esptool_py waveshare_esp32s3_touch_lcd_128.upload.tool.default=esptool_py @@ -40584,8 +40578,6 @@ walter.menu.EraseFlash.all.upload.erase_cmd=-e ############################################################## elecrow_crowpanel_7.name=Elecrow CrowPanel 7.0P -elecrow_crowpanel_7.vid.0=0x1a86 -elecrow_crowpanel_7.pid.0=0x7523 elecrow_crowpanel_7.upload.tool=esptool_py elecrow_crowpanel_7.upload.tool.default=esptool_py