Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in master merged with PR #7022: WDT resets #7127

Closed
dok-net opened this issue Mar 2, 2020 · 3 comments
Closed

Regression in master merged with PR #7022: WDT resets #7127

dok-net opened this issue Mar 2, 2020 · 3 comments

Comments

@dok-net
Copy link
Contributor

dok-net commented Mar 2, 2020

Details in #7022 and #7121.
PR #7022 works without lock-ups or reboots up to and including master commit 2c435b1. So commit c61b70d introduces some change that breaks the timing and causes continual WDT resets (1 per minute or so) in the MVCE I've supplied in #7121.
Without PR #7022, I have not been able to reproduce this malfunction, but that shouldn't make it any less significant.

@dok-net
Copy link
Contributor Author

dok-net commented Mar 2, 2020

@d-a-v The connect to the PR #7022 was mentioned in #7121 ("waveform" intended to mean the waveform PR, made clear by the immediate reference to PR #7022 in the same breath). Sorry to have caused any distress over this.

@dok-net dok-net changed the title Regession in master merged with PR #7022 Regession in master merged with PR #7022: WDT resets Mar 2, 2020
@dok-net
Copy link
Contributor Author

dok-net commented Mar 2, 2020

To be clear, OTA is included in the MCVE because it's in the actual complete code that I am working with. OTA is not in use when the WDT triggers, just the requisite call in loop() is there.
If OTA is removed from the sources, the WDT does not trigger. If only #7036 is reverted, the WDT still triggers, but is observed less frequently. Reverting #7121 mitigates the WDT issue completely.

@dok-net dok-net changed the title Regession in master merged with PR #7022: WDT resets Regression in master merged with PR #7022: WDT resets Mar 2, 2020
@dok-net
Copy link
Contributor Author

dok-net commented Mar 4, 2020

WDT resets were fixed by #7121, then finally merged via #7131

@dok-net dok-net closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant