Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary signing should be available under Windows #5694

Closed
Misiu opened this issue Jan 29, 2019 · 5 comments
Closed

Binary signing should be available under Windows #5694

Misiu opened this issue Jan 29, 2019 · 5 comments
Assignees
Milestone

Comments

@Misiu
Copy link

Misiu commented Jan 29, 2019

This PR adds support for signing binary file with certificate.
Unfortunately it is available only on Linux and Mac.
As suggested by @earlephilhower I'm oppening this issue to track support for Windows.

OpenSSL it is easily installable on Windows - https://wiki.openssl.org/index.php/Binaries.
I don't mind manual installation of it, especially is it done only once.
If installing OpenSSL manually and adding it to the path (so that OpenSSL executable is available from the command line) is the only step then this should be definitively added to docs.

@earlephilhower
Copy link
Collaborator

This would be predicated on #5635. If we don't include Python by default w/the Windows install, this isn't (sanely) possible.

@Misiu
Copy link
Author

Misiu commented Jan 31, 2019

@earlephilhower if Python will be installed on Windows (manual step is done one by the user) then this is doable?
I think that everybody who needs binary signing will manage to install Python by themselves.
I'm using PlatformIO with Visual Studio Code, so Python is one of the requirements.

@earlephilhower
Copy link
Collaborator

@Misiu, the problem is if python is not installed the IDE will abort when you try and start the signing.py script and it won't ever successfully build a BIN.

The referenced PR installs a complete copy of python as part of the core subdirectory, so we can safely call that tool on all Windows boxes and signing.py can then gracefully exit if OpenSSL isn't present.

@earlephilhower
Copy link
Collaborator

Signing should now work if OpenSSL command line utilities are installed since #5635 was merged.

Misiu referenced this issue Sep 11, 2019
* Edited OTA readme, added Stream Interface snippet

Reworded for easier understanding. Changes mostly in first half of page.

* OTA docs: corrected typos, misc edits near end

* Incorporated suggestions from earlephilhower

Extra ^, removed TODO
@fa1rid
Copy link

fa1rid commented May 2, 2020

I have both Python and openSSL installed and added to the path but I get this error:
[WinError 2] The system cannot find the file specifiedNot signing the generated binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants