Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266Webserver warning on string concat #4354

Closed
Sparatutto opened this issue Feb 12, 2018 · 3 comments
Closed

ESP8266Webserver warning on string concat #4354

Sparatutto opened this issue Feb 12, 2018 · 3 comments

Comments

@Sparatutto
Copy link

Recently I have updated the library as you suggested me with the GIT and I have a warning on a string concatenation.
Second I see new iwIp variant names and not sure what they are.
One is for memory saving and the second for bandwidth. Not sure the meaning of this second.

I'm compiling with the warning and I did test both iwip.
No difference with the two version and no issues with the warning.

Hardware

image

Description

I think + ':auth:' should be with "" instead.

Sketch


### Debug Messages

:\Program Files (x86)\Arduino\hardware\esp8266com\esp8266\libraries\ESP8266WebServer\src\ESP8266WebServer.cpp:198:93: warning: character constant too long for its type [enabled by default]

     md5.add(_H1 + FPSTR(colon) + _nonce + FPSTR(colon) + _nc + FPSTR(colon) + _cnonce + ':auth:' + _H2);

                                                                                         ^


@earlephilhower
Copy link
Collaborator

Please try the GIT latest. Commit #4338 fixes this and a few other problems.

@Sparatutto
Copy link
Author

@earlephilhower thanks, i will try to update tomorrow.
FYI, i did update on friday and the fix seems to be before my git.
Anyway I will tr tomorrow.
thx!

@Sparatutto
Copy link
Author

Updated now. Ok no more warning. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants