Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch using Timezone-Lib will not compile in v2.4.0 #4106

Closed
digi-thomas2003 opened this issue Jan 6, 2018 · 5 comments
Closed

Sketch using Timezone-Lib will not compile in v2.4.0 #4106

digi-thomas2003 opened this issue Jan 6, 2018 · 5 comments

Comments

@digi-thomas2003
Copy link

Basic Infos

Hardware

Hardware: NodeMCU 1.0
Core Version: 2.4.0

Description

Any sketch using the Timezone-library from JChristensen will not compile with 2.4.0
There are lots of "... is not declared in this scope" errors referencing to the Timezone lib

Going back to 2.3.0 the compilations run fine without any error.

Can this please be checked? Thanks a lot.

Best regards

@5chufti
Copy link
Contributor

5chufti commented Jan 6, 2018

most likely a problem with your includes (sequence of).
without your sketch not reproducable
BUT: why use third party TZlib when newlibc allready supports TZ stuff?
e.g. see here: #1679 (comment)

@digi-thomas2003
Copy link
Author

digi-thomas2003 commented Jan 6, 2018

Hello Schufti (and d-a-v),

is there a kind of documentation how to use the core time functions (like configTime and the time struct)?
And the newlib and these tzset settings?

In issue #1679 you also asked for some kind of documentation...

Thanks to all.

Meanwhile I solved my problem from the opening post: In the folder of the the TimeLib-library I renamed "Time.cpp" to "TimeLib.cpp". Now the compilation is successfull.

@5chufti
Copy link
Contributor

5chufti commented Jan 7, 2018

one can find the newlib documentation here
https://sourceware.org/newlib/libc.html

so since your - not core related - problem is solved, may you please close this issue?

@digi-thomas2003
Copy link
Author

as desired

@digi-thomas2003
Copy link
Author

digi-thomas2003 commented Jan 10, 2018

Is related to #4122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants