Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use http.setAuthorization for ESPhttpUpdate #3812

Closed
pjunni opened this issue Nov 9, 2017 · 8 comments
Closed

Unable to use http.setAuthorization for ESPhttpUpdate #3812

pjunni opened this issue Nov 9, 2017 · 8 comments
Labels
component: libraries type: enhancement waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.

Comments

@pjunni
Copy link

pjunni commented Nov 9, 2017

I did not find a way to use http.setAuthorization for ESPhttpUpdate, but I solved the issue by adding the line http.setAuthorization("username","password"); on line 181 in https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266httpUpdate/src/ESP8266httpUpdate.cpp. Is there a more "correct" way to do this or could there be an overloaded handleUpdate function that takes these "username" and "password" and pass them into http.setAuthorization("username","password");?

@devyte
Copy link
Collaborator

devyte commented Nov 10, 2017

@pjunni if I understand the request correctly, what you want to do is update from a webserver that requires user/pass. Is that correct?

@devyte devyte added the waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. label Nov 10, 2017
@pjunni
Copy link
Author

pjunni commented Nov 13, 2017

@devyte That's correct.

@pjunni
Copy link
Author

pjunni commented Nov 23, 2017

@devyte Would you have any suggestions on this matter?

@jatayu86
Copy link

I face the similar issue,could someone please let us know how to add http authorization headers for ESPHttpUpdate?

@ngashok
Copy link

ngashok commented Apr 26, 2019

Facing same issue. How to do OTA from https server having authorisation with username/password.

@Swiftnesses
Copy link

Was this ever solved, I have the same issue?

@drhideg
Copy link
Contributor

drhideg commented Apr 10, 2020

If you are still interested, would you give it a try this PR? #7190

@earlephilhower
Copy link
Collaborator

Fixed via the mentioned PR (#7190). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: libraries type: enhancement waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

No branches or pull requests

7 participants