Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

CriticalSectionSpinLockMutex shouldn't be available for targets w/o atomics support #16

Closed
bjoernQ opened this issue Feb 10, 2022 · 2 comments · Fixed by #17
Closed

CriticalSectionSpinLockMutex shouldn't be available for targets w/o atomics support #16

bjoernQ opened this issue Feb 10, 2022 · 2 comments · Fixed by #17
Assignees
@MabezDev

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Feb 10, 2022

The ESP32S2 doesn't support atomics so we should either configure CriticalSectionSpinLockMutex away in that case or emulate it with just a critical section (which would be okay since ESP32S2 is single-core)
@jessebraham
Copy link
Member

jessebraham commented Apr 19, 2022 •
edited
Loading

This has finally reared its head with the 1.60.0.1 release of the Xtensa fork. Building for the ESP32-S2 fails, see output here:
https://gist.github.com/jessebraham/7f4cd81892ad2f5dc8d5decd4ff8a26f

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Apr 19, 2022

I guess "configure CriticalSectionSpinLockMutex away" (including the dependency) is the easiest solution here - we should just do it

@jessebraham jessebraham mentioned this issue Apr 19, 2022
Merged
@MabezDev MabezDev self-assigned this Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MabezDev MabezDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more chip features and cfg away spin for the ESP32-S2 and ESP8266
3 participants
@jessebraham @bjoernQ @MabezDev