Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Windows executable release artefacts #348

Closed
SergioGasquez opened this issue Jan 31, 2023 · 2 comments
Closed

Sign Windows executable release artefacts #348

SergioGasquez opened this issue Jan 31, 2023 · 2 comments
Assignees

Comments

@SergioGasquez
Copy link
Member

As @georgik requested, we could sign Windows executables the same way we do it for espup.

It would be really cool if we had a signing mechanism in esp-rs, as doing it in idf-env repo is not the best solution (its a completely unrelated repo and it requires some manual steps)

@jessebraham
Copy link
Member

I think that essentially everybody installs via cargo install anyway, I've never heard anybody mention this issue before, so not sure what impact it will have in reality. But I suppose as long as it doesn't complicate the release process too much we can do it.

@jessebraham jessebraham added this to the v2 milestone Feb 1, 2023
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Feb 1, 2023
@jessebraham jessebraham removed this from the v2 milestone May 29, 2023
@jessebraham
Copy link
Member

I'm just going to go ahead and say this isn't worth pursuing at this time. We can revisit it in the future if it becomes a necessity.

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants