Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add an autoformatter #24

Closed
TheButlah opened this issue Nov 22, 2022 · 1 comment · Fixed by #28
Closed

Add an autoformatter #24

TheButlah opened this issue Nov 22, 2022 · 1 comment · Fixed by #28
Assignees

Comments

@TheButlah
Copy link
Contributor

I tried to create a PR and had a lot of trouble, because the code isn't formatted with rustfmt. I therefore needed to manually go through and delete everything that got formatted, so that I didn't submit a bunch of formatting noise and risk getting my PR rejected.

Would it be ok to add a rustfmt.toml file to the repo to indicate that the use of an autoformatter is permissible in PRs and define the format?

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 22, 2022

With the default formatter settings, I get some changes in the macros, true. I'm wondering if you experienced more changes?

Anyway - sure - makes sense to add a rustfmt.toml - ideally this one https://github.com/esp-rs/esp-hal/blob/main/rustfmt.toml

@jessebraham jessebraham self-assigned this Nov 22, 2022
@jessebraham jessebraham moved this to Todo in esp-rs Nov 22, 2022
Repository owner moved this from Todo to Done in esp-rs Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants