Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test_asymmetric_dma_transfer for S3 #1888

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

SergioGasquez
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Disables the failing test for S3, so we get the workflow back to green and we can reenable the required check.

Testing

https://github.com/esp-rs/esp-hal/actions/runs/10182650638

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Jul 31, 2024
@SergioGasquez
Copy link
Member Author

Just added HIL Test | esp32s3 as a required check

Merged via the queue into esp-rs:main with commit 40d5481 Jul 31, 2024
18 checks passed
@jessebraham
Copy link
Member

I2S is now failing for the S3 in HIL. Don't think we're ready to make this a required check yet.

@SergioGasquez
Copy link
Member Author

I2S is now failing for the S3 in HIL. Don't think we're ready to make this a required check yet.

Thanks for disabling it again, Ill have a look tomorrow to see what is failing

@SergioGasquez SergioGasquez deleted the feat/disable-failing-test branch July 31, 2024 16:24
@SergioGasquez
Copy link
Member Author

Just tried locally, and I was able to reproduce the transient failures on the I2S test for S3, might be related to the DMA issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants