Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some modules documentation #1726

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Updated the module documentation of I2C, LEDC and UART. Documents how to invert signals in UART (#1216)

Testing

I've run run-doc-test of xtask

@SergioGasquez SergioGasquez linked an issue Jun 27, 2024 that may be closed by this pull request
@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Jun 27, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good to me! I did just notice one small typo though, if you don't mind fixing it.

esp-hal/src/uart.rs Outdated Show resolved Hide resolved
@jessebraham jessebraham added this pull request to the merge queue Jun 27, 2024
Merged via the queue into esp-rs:main with commit d0cd890 Jun 27, 2024
30 checks passed
@SergioGasquez SergioGasquez deleted the feat/docs branch June 28, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uart: polarity inversion
3 participants