Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping #1647

Merged
merged 3 commits into from
May 31, 2024
Merged

Housekeeping #1647

merged 3 commits into from
May 31, 2024

Conversation

jessebraham
Copy link
Member

Nothing particularly interesting here, just various little things I wanted to clean up before the release:

  • README.md files have consistent badges now
  • Fixed a build warning in esp-println when targeting ESP32-S2
  • Removed versions from examples/hil-test packages for path dependencies (suggested by @SergioGasquez in another PR)

@jessebraham jessebraham added the skip-changelog No changelog modification needed label May 31, 2024
SergioGasquez
SergioGasquez approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

JurajSadel
JurajSadel approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue May 31, 2024
Merged via the queue into esp-rs:main with commit 40c327e May 31, 2024
23 checks passed
@jessebraham jessebraham deleted the fixes/housekeeping branch May 31, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessebraham @SergioGasquez @JurajSadel