Adapt HIL tests to use RPi #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
feat/hil-c6-rpi
branch
from
022187b
to
aa3b4dd
Compare
MabezDev
reviewed
Apr 22, 2024
SergioGasquez
commented
Apr 22, 2024
|
Sorry I've obviously missed something, why are we doing this? |
Our VMs started failing in some weird ways due to out of memory, and we couldnt get them back to a working state (even removing some VMs and only using the same VMs (or less) as they were before everything started breaking. |
MabezDev
reviewed
Apr 22, 2024
SergioGasquez
force-pushed
the
feat/hil-c6-rpi
branch
from
aa3b4dd
to
903d4c4
Compare
|
Just reran the workflow to verify that it works with latest changes and its still green: https://github.com/esp-rs/esp-hal/actions/runs/8785445616 |
MabezDev
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Only enables C6 for the moment
Testing
Manually triggered the workflow: https://github.com/esp-rs/esp-hal/actions/runs/8785445616