Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some #[allow] attributes and an unused function #1440

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

jessebraham
Copy link
Member

No description provided.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I wonder why cache_ibus_mmu_set and cache_dbus_mmu_set were marked as TODO .... probably it was like that in esp-idf and this just got copied. Not important ... just wondering

@MabezDev MabezDev added this pull request to the merge queue Apr 16, 2024
Merged via the queue into esp-rs:main with commit 5867440 Apr 16, 2024
22 checks passed
@jessebraham jessebraham deleted the fixes/housekeeping branch April 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants