Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AES DMA HIL Tests #1426

Merged
merged 4 commits into from
Apr 15, 2024
Merged

AES DMA HIL Tests #1426

merged 4 commits into from
Apr 15, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 12, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Adds AES DMA HIL tests for every AES mode.

I really tried to use Context as with other tests, but Rust compiler just wasn't happy with the types and all the movements of them, so I ended up copy/pasting it all over, which makes it really ugly.

Had to add a reset_aes call at the end of finish_transform to clear the interrupt as otherwise, the aes test failed, see https://github.com/esp-rs/esp-hal/actions/runs/8659868769

Testing

Tested locally on S3, C6 and H2.

Manually triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/8685641126

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Apr 12, 2024
@SergioGasquez SergioGasquez changed the title Feat/hil aes dma AES DMA HIL Tests Apr 12, 2024
@SergioGasquez SergioGasquez marked this pull request as draft April 12, 2024 09:32
@SergioGasquez SergioGasquez marked this pull request as ready for review April 15, 2024 08:17
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Apr 15, 2024
Merged via the queue into esp-rs:main with commit 6341912 Apr 15, 2024
21 checks passed
@SergioGasquez SergioGasquez deleted the feat/hil-aes_dma branch April 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants