Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular DMA #1144

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fix circular DMA #1144

merged 3 commits into from
Feb 8, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 6, 2024

Fixes #1142

This fixes a subtle bug which was discovered in #1142

@thedevleon mind testing if this fixes your original issue?

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this resolves the issue (pending results) this looks fine, so feel free to merge whenever.

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 8, 2024

@jessebraham there are new clippy lints triggering as of today's nightly - and at least the thing about AesFlavour might be a false-positive. I wonder if we should limit clippy to the MSRV toolchain? We could get a bunch of new warnings/errors whenever we raise the MSRV then but with nightly we can get new (and especially unrelated) warnings out of a sudden with nightly - not sure what would be the best way to go ... I could probably mute those lints here but having totally unrelated changes in random PRs doesn't sound pleasant to me 🤔

@thedevleon
Copy link

thedevleon commented Feb 8, 2024

@thedevleon mind testing if this fixes your original issue?

Yes, the embassy_i2s_sound sample now produces a noise-free sine wave without any additional modifications to the sample itself.

@MabezDev MabezDev added this pull request to the merge queue Feb 8, 2024
Merged via the queue into esp-rs:main with commit ca58da4 Feb 8, 2024
17 checks passed
@bjoernQ bjoernQ deleted the fix/circular-dma branch November 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2S audio from esp32-c3 is mostly noise
4 participants