We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to re-export more of esp-hal-common since that shouldn't be used directly
esp-hal-common
Background: When implementing https://github.com/bjoernQ/ps2keyboard-esp32c3 I discovered I need to import a few things that are actually in esp-hal-common and are not re-exported:
use esp_hal_common::{Event, OpenDrain, Output, Pin};
The text was updated successfully, but these errors were encountered:
Removed the "good first issue" label since I think it's because of module shadowing: https://rust-lang.github.io/rfcs/0116-no-module-shadowing.html
So basically, we need to export those items in different namespaces - question is how to name them?
Sorry, something went wrong.
bjoernQ
Successfully merging a pull request may close this issue.
We need to re-export more of
esp-hal-common
since that shouldn't be used directlyBackground:
When implementing https://github.com/bjoernQ/ps2keyboard-esp32c3 I discovered I need to import a few things that are actually in
esp-hal-common
and are not re-exported:use esp_hal_common::{Event, OpenDrain, Output, Pin};
The text was updated successfully, but these errors were encountered: