Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More re-exports in the chip specific HALs needed #68

Closed
bjoernQ opened this issue Jun 2, 2022 · 1 comment · Fixed by #81
Closed

More re-exports in the chip specific HALs needed #68

bjoernQ opened this issue Jun 2, 2022 · 1 comment · Fixed by #81
Assignees

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Jun 2, 2022

We need to re-export more of esp-hal-common since that shouldn't be used directly

Background:
When implementing https://github.com/bjoernQ/ps2keyboard-esp32c3 I discovered I need to import a few things that are actually in esp-hal-common and are not re-exported:

use esp_hal_common::{Event, OpenDrain, Output, Pin};

@bjoernQ bjoernQ added the good first issue Good for newcomers label Jun 2, 2022
@jessebraham jessebraham moved this to Todo in esp-rs Jun 2, 2022
@bjoernQ bjoernQ removed the good first issue Good for newcomers label Jun 8, 2022
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Jun 8, 2022

Removed the "good first issue" label since I think it's because of module shadowing: https://rust-lang.github.io/rfcs/0116-no-module-shadowing.html

So basically, we need to export those items in different namespaces - question is how to name them?

@bjoernQ bjoernQ self-assigned this Jun 13, 2022
Repository owner moved this from Todo to Done in esp-rs Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants