Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32s3 usb_serial.rs example not working #495

Closed
PocketPi opened this issue Apr 27, 2023 · 6 comments · Fixed by #656
Closed

esp32s3 usb_serial.rs example not working #495

PocketPi opened this issue Apr 27, 2023 · 6 comments · Fixed by #656
Assignees
Labels
bug Something isn't working

Comments

@PocketPi
Copy link

When i try to setup the usb_serial.rs example it first of all do not compile.

I have to modify the arguments given to TimerGroup::new. I have to remove third argument: &mut system.peripheral_clock_control,

When i then build it and flash it and plug it into my pc the usb port is not showing up and i get a lot of usb errors.

When looking a bit more in the code it looks like the usb_dp and usb_dm are swapped, im using a T-Displat-S3 from Lilygo, but it also looks like the esp32-s3-devkit-c is having the same pinout: https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html

Can anyone help me figure out how to fix the issue?

@bjoernQ bjoernQ added the bug Something isn't working label Apr 27, 2023
@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 27, 2023

Regarding the problems compiling it: You probably didn't run the example inside the repo? There is a breaking change regarding the TimerGroup initialization

It definitely worked before but I can confirm it stopped working

We need to check which commit broke it

@PocketPi
Copy link
Author

Correct i have used the template generator tool to make a new project and then copied the code to the generated project

@PocketPi
Copy link
Author

the compiling issue was introduced with this pr: #463

@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 27, 2023

@MabezDev this is a Rust compiler issue apparently .... it works (even with current main) with the Xtensa-enabled Rust compiler 1.65 and 1.66 but not with 1.67, 1.68 or 1.69 👻

@PocketPi
Copy link
Author

I also think that there is a problem with the crate, i can see in you example that you point directly to github and that you do not just let cargo get it from the crates registry

@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 27, 2023

I also think that there is a problem with the crate, i can see in you example that you point directly to github and that you do not just let cargo get it from the crates registry

Yes, at the time of writing that example we haven't had a release of esp-hal including usb-device support yet

@bjoernQ bjoernQ self-assigned this Jul 14, 2023
@bjoernQ bjoernQ moved this from Todo to In Progress in esp-rs Jul 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in esp-rs Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants