Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eh0.2 impls and dependency from esp-lp-hal #2597

Closed
playfulFence opened this issue Nov 25, 2024 · 0 comments · Fixed by #2609
Closed

Remove eh0.2 impls and dependency from esp-lp-hal #2597

playfulFence opened this issue Nov 25, 2024 · 0 comments · Fixed by #2609
Assignees
@playfulFence
Labels
package:esp-lp-hal Issues related to the esp-lp-hal package peripheral:i2c I2C peripheral

Comments

@playfulFence
Copy link
Contributor

playfulFence commented Nov 25, 2024 •
edited by jessebraham
Loading

Even though this package is out of our current scope, we need to completely remove eh0.2 imports from our infrastructure.

To do this, we need to implement embedded_hal::i2c::I2c trait for our LpI2c which will allow us to remove eh0.2 dependency from this crate.
@playfulFence playfulFence added peripheral:i2c I2C peripheral package:esp-lp-hal Issues related to the esp-lp-hal package beta-blocker labels Nov 25, 2024
@playfulFence playfulFence self-assigned this Nov 25, 2024
@MabezDev MabezDev added low power Light-/Deep-Sleep and co-processor support and removed beta-blocker low power Light-/Deep-Sleep and co-processor support labels Nov 25, 2024
@playfulFence playfulFence mentioned this issue Nov 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@playfulFence playfulFence

Labels
package:esp-lp-hal Issues related to the esp-lp-hal package peripheral:i2c I2C peripheral
Projects
esp-rs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove embedded-hal 0.2.x impls and dependency from esp-lp-hal package playfulFence/esp-hal
2 participants
@MabezDev @playfulFence