Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embassy_interrupt_spi_dma: C2, C3, C6, H2 - need to use a different DMA-enabled peripheral #2289

Closed
Tracked by #1524
tom-borcin opened this issue Oct 7, 2024 · 5 comments · Fixed by #2490
Closed
Tracked by #1524
Assignees
Labels
tests Unit, Integration, or Hardware-in-Loop Testing
Milestone

Comments

@tom-borcin
Copy link

tom-borcin commented Oct 7, 2024

Issue created from #1524

@github-project-automation github-project-automation bot moved this to Todo in esp-rs Oct 7, 2024
@tom-borcin tom-borcin added this to the 0.22.0 milestone Oct 7, 2024
@SergioGasquez SergioGasquez added the tests Unit, Integration, or Hardware-in-Loop Testing label Oct 9, 2024
@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 6, 2024

I'm not quite sure what this issue is asking for. The mentioned targets only contain one GP-SPI

While it's technically possible to use SPI1 we don't support that and I'm not sure if we ever will or should (I'd personally say we shouldn't)

@bugadani
Copy link
Contributor

bugadani commented Nov 6, 2024

The idea is to use I2S on these devices (or all of them).

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 6, 2024

The idea is to use I2S on these devices (or all of them).

Ok nice - C2 doesn't include I2S IIRC but at least this clarifies the issue a bit

@bugadani
Copy link
Contributor

bugadani commented Nov 6, 2024

To be honest this is a bit of a non-issue anyway. With the Xtensas we have a test for both PDMA and GDMA devices and the original issue wasn't exactly device-specific.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 8, 2024

Hint: the PR which introduced the test is #2065

@bjoernQ bjoernQ self-assigned this Nov 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Unit, Integration, or Hardware-in-Loop Testing
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants