Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Provide consistent APIs for configuring clock sources for peripheral drivers #1668

Open
jessebraham opened this issue Jun 10, 2024 · 3 comments
Labels
1.0-blocker RFC Request for comment

Comments

@jessebraham
Copy link
Member

From this project's inception we've just been hard-coding the clock source for peripheral drivers (usually just using the default clock source). This has been done just to keep things simple. We've reached the point that I feel we should start thinking more about this. I think it should not be too difficult to provide consistent APIs for configuring clock sources.

(I have not thought about this much (or at all, really) yet but I will update this comment once I have a better idea of what we should actually do about this)

@jessebraham jessebraham added the RFC Request for comment label Jun 10, 2024
@playfulFence
Copy link
Contributor

I guess conceptually it should be something like #1416, right?

@sunsoan
Copy link

sunsoan commented Oct 16, 2024

I guess conceptually it should be something like #1416, right?

yes,some other peripheral also need a method to config clock source

@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Nov 20, 2024
@MabezDev
Copy link
Member

I changed my mind, this isn't a beta blocker but a 1.0 blocker - I've added a note in #2495 (the only driver where we set the clock source) to mark it as unstable until we figure out a full solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0-blocker RFC Request for comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants