Refactor SPI tests & re-enable S3 and some S2 (#1990)

* Deduplicate spi_full_duplex_dma_async

* Refactor SPI tests

* Separate out PCNT tests

* Re-enable test on S3

* Re-enable some S2 tests

hil-test/Cargo.toml

@@ -79,6 +79,10 @@ harness = false
 name    = "spi_full_duplex_dma_async"
 harness = false
 
+[[test]]
+name    = "spi_full_duplex_dma_pcnt"
+harness = false
+
 [[test]]
 name    = "spi_half_duplex_read"
 harness = false

hil-test/tests/spi_full_duplex.rs

@@ -28,8 +28,15 @@ struct Context {
     spi: Spi<'static, esp_hal::peripherals::SPI2, FullDuplexMode>,
 }
 
-impl Context {
-    pub fn init() -> Self {
+#[cfg(test)]
+#[embedded_test::tests]
+mod tests {
+    use defmt::assert_eq;
+
+    use super::*;
+
+    #[init]
+    fn init() -> Context {
         let peripherals = Peripherals::take();
         let system = SystemControl::new(peripherals.SYSTEM);
         let clocks = ClockControl::boot_defaults(system.clock_control).freeze();
@@ -49,19 +56,6 @@ impl Context {
 
         Context { spi }
     }
-}
-
-#[cfg(test)]
-#[embedded_test::tests]
-mod tests {
-    use defmt::assert_eq;
-
-    use super::*;
-
-    #[init]
-    fn init() -> Context {
-        Context::init()
-    }
 
     #[test]
     #[timeout(3)]