Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build when platform-specific overrides are necessary in tools.json #87

Closed
tomstokes opened this issue Jun 14, 2024 · 3 comments

Comments

@tomstokes
Copy link
Contributor

The custom tools parsing code from #85 does not process the overrides from tools.json.

This breaks the build on macOS and likely several other platforms. PR incoming to fix it.

@Vollbrecht
Copy link
Collaborator

Thanks for the PR's i will review them tomorrow! Its sleep time for me now.

Only one heads up regarding the matching off the ARCH. The linked rust documentation at that point doesn't help because it only shows some possible values. Still possible wrong the way it is currently. I think rust itself takes the value from the target-description, and if we check at least the supported platforms or better directly check in the rustc source, we should check the arch value inside the target description.

If my memory is not totally wrong you can compile against rpi3 for example with armv7_unknown_linux_muslabi as well as armv7_unknown_linux_gnuabi(hf). In that cases it really seams to only use "arm" as the ARCH value. Question is if that is consistent for the rest of the target in that list.

@tomstokes
Copy link
Contributor Author

Question is if that is consistent for the rest of the target in that list.

That's a good question. I spot checked a few of the rust compiler Target definitions before I submitted the PR, but I didn't check all of them. The ones I saw used arm, but of course that doesn't mean there's not a different one hidden in there somewhere.

@Vollbrecht
Copy link
Collaborator

closed with #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants