Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify (optional) our advanced search behavior to closer (not exact) match community needs #326

Closed
DiegoPino opened this issue Jun 21, 2023 · 2 comments
Assignees
Labels
Drupal Views Ask and you should receive enhancement New feature or request Release duties Search and Discovery Mess around and find out Search API Sub Modules When you need more .info.yml files to keep life organized UX Like UI but with an X
Milestone

Comments

@DiegoPino
Copy link
Member

and @alliomeria's one too

What

We discussed today some needs on Advanced search with @alliomeria and conclusions are:

  • add more/remove should have an option for not triggering a search (this is hard since they need to rebuild the form and thus, once Ajax is in place, return a view, this is the Drupal way). I will try to mimic how the "required" filter option works or intercept the query. Issue I see is IF there was already a submission (means I searched for "pumpkin" and got results) and I press "add one", add "Dog" I need to still keep the old results where "pumpkin" was searched. OR I could intercept the Ajax response and simply NOT return any changes, thus the actual View would be still changed and thus the facets would not match... hard
  • When using "required" option on the advanced search filter, we can actually start with an empty view but we have no control on the message that displays (No results found). the idea here is that if no input has been given we either use the Message provided by the Advanced Tab, Exposed Input, Input required special form
    image or none, but never "No results found"
  • Pressing enter on the form should not trigger add one/remove one. Should always submit the search.
  • Selection of Field names should allow a "rewrite". That requires a new pattern/field with replacement options.

So far this is what I have. This is a lot of code but sadly for me needed for the release.

@DiegoPino DiegoPino added enhancement New feature or request Release duties UX Like UI but with an X Search and Discovery Mess around and find out Drupal Views Ask and you should receive Search API Sub Modules When you need more .info.yml files to keep life organized labels Jun 21, 2023
@DiegoPino DiegoPino added this to the 1.1.0 milestone Jun 21, 2023
@DiegoPino DiegoPino self-assigned this Jun 21, 2023
@DiegoPino
Copy link
Member Author

😢

@DiegoPino
Copy link
Member Author

Solved via 715eb8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal Views Ask and you should receive enhancement New feature or request Release duties Search and Discovery Mess around and find out Search API Sub Modules When you need more .info.yml files to keep life organized UX Like UI but with an X
Projects
None yet
Development

No branches or pull requests

1 participant