Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xdebug for RC3 #114

Closed
DiegoPino opened this issue Jul 29, 2021 · 3 comments · Fixed by #115
Closed

Update Xdebug for RC3 #114

DiegoPino opened this issue Jul 29, 2021 · 3 comments · Fixed by #115
Assignees
@DiegoPino
Labels
Docker Containers All about those tiny little critters enhancement New feature or request
Milestone
1.0.0-RC3

Comments

@DiegoPino
Copy link
Member

What?

Yep, xdebug version 3 (I still love error_log but Ok, this sounds reasonable!)

  • Update Container (done!) to match PHP 7.4.20
  • Update docker-compose.dev.yml for XDEBUG 3
  • Add a custom php.ini
  • Add instructions to archipelago-documentation (simpler now)
@DiegoPino DiegoPino self-assigned this Jul 29, 2021
@DiegoPino DiegoPino added Docker Containers All about those tiny little critters enhancement New feature or request labels Jul 29, 2021
@DiegoPino DiegoPino added this to the 1.0.0-RC3 milestone Jul 29, 2021
@DiegoPino DiegoPino linked a pull request Jul 29, 2021 that will close this issue
ISSUE-114: make Xdebug 3 work on archipelago-deployment RC3 #115
Merged
@aksm aksm closed this as completed Nov 5, 2021
@DiegoPino
Copy link
Member Author

@aksm is this also true for RC3D9? Please give me your thumbs if so

@aksm
Copy link
Contributor

aksm commented Nov 5, 2021

@DiegoPino Whoops, no. Will work on that now.

@aksm aksm reopened this Nov 5, 2021
@aksm aksm mentioned this issue Nov 5, 2021
Merged
@DiegoPino
Copy link
Member Author

Solved by super duper @aksm via b4b28db

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
Docker Containers All about those tiny little critters enhancement New feature or request
Projects
None yet
Milestone
1.0.0-RC3
Development

Successfully merging a pull request may close this issue.

ISSUE-114: make Xdebug 3 work on archipelago-deployment RC3 esmero/archipelago-deployment
2 participants
@DiegoPino @aksm