obcommand inserts name of command instead of executing it

[tprotopopescu]

Please Review Before Posting!

• I checked that the bug does not happen in the CodeMirror Vim demo. If it does, please report it there and not here.
• I'm reasonably sure that this bug is indeed about the Vimrc file support and not a general Vim in Obsidian issue. If it's a general Vim issue, report it here.

Describe the bug:

obcommands no longer execute the command but instead insert the name of the command. If in insert mode then the name of the command ':mycommand' is inserted, in normal mode the command line is opened and the name of the command inserted there.

To Reproduce:

Add the following to obsidian.vimrc file:

exmap highlighttext obcommand editor:toggle-highlight imap === :highlighttext nmap '= :highlightext

In insert mode typing '===' should toggle highlight, instead it inserts the text ':highlighttext'.

In normal mode typing " '= " should toggle highlight, instead it opens the vim command line and inserts the text 'highlighttext'.

Environment (please complete the following information):

• OS: Linux (opensuse 15.6)
• Vimrc plugin version: 0.10.2
• Obsidian: 1.7.7
• Installer: 1.6.7

Additional context:

Add any other context about the problem here.

Reproduced in a sandbox vault with only vimrc plugin installed. I can say for sure this was working for me on versions 0.7.x; tried downgrading with BRAT and the problem persists, so it is probably something in obsidian that has changed which breaks the obcommands.

[ko-shin-ryo]

With the update to Obsidian 1.7.2, executing Ex commands now requires appending <CR>.

Transitioning from Insert mode to Command-line mode may work as expected if you pass through Normal mode first. In such cases, you might consider appending a immediately after the command to return to Insert mode seamlessly.

Based on this, the following .obsidian.vimrc configuration should work as intended:

exmap highlighttext obcommand editor:toggle-highlight
imap === <Esc>:highlighttext<CR>a
nmap '= :highlighttext<CR>

[tprotopopescu]

Thank you, thank you! I got the commands working. Should I mark this as closed? Or is this something that will be changed in upcoming versions?