fix: Package-specific migration bugs #107
Merged
+108
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +84,7 @@ describe("@eslint/migrate-config", async () => { | |||
| // run the migration for mjs | |||
| execSync( | |||
| `node src/migrate-config-cli.js ${filePath} ${gitignoreFlag}`, | |||
| { stdio: "inherit" }, | |||
There was a problem hiding this comment.
Is this change intentionally committed?
There was a problem hiding this comment.
Yes. Otherwise the errors are swallowed during testing.
mdjermanovic
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
LGTM if #107 (comment) is intentional. Otherwise, LGTM when it's removed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fix some bugs reported in eslint/eslint#18453 (reply in thread).
What changes did you make? (Give an overview)
/in their name are properly converted into JavaScript variablescompat-config.jsas a list of shareable configs that are known to require the compat utility (addedeslint-config-react-appas the only known one for now).Related Issues
Is there anything you'd like reviewers to focus on?