New: add support for meta info in code blocks #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If someone already has extra meta info after the opening fence, adding it to the virtual filename would be a breaking change. I've labeled this as such, though I'm optimistic #170 could be solved in a non-breaking way. Let's focus discussion there for now. |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Mar 6, 2021
Refs: nodejs#37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: nodejs#37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 16, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
|
Closing as the underlying issue has been solved another way! |
targos
pushed a commit
to nodejs/node
that referenced
this pull request
May 30, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 5, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 5, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 11, 2021
Refs: #37162 Refs: nodejs/remark-preset-lint-node#176 PR-URL: #37311 Refs: eslint/markdown#172 Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #170
Blocked on #171