feat: Add disable comment support #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @eslint/eslint-team |
We don't want to implement this or we'll implement it in another PR? |
|
We can implement it in a separate PR. Just wanted to keep this PR focused on the disable directives. |
src/language/markdown-source-code.js
Outdated
| end.column = | ||
| commentLineCount === 0 | ||
| ? start.column + comment.length | ||
| : comment.length - comment.lastIndexOf("\n") - 1; |
There was a problem hiding this comment.
Suggested change
| : comment.length - comment.lastIndexOf("\n") - 1; | |
| : comment.length - comment.lastIndexOf("\n"); |
As the columns are 1-based in this language.
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
mdjermanovic
approved these changes
Sep 30, 2024
|
Ping @aladdin-add |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for disable comments to the Markdown plugin. It supports all of the variations that ESLint supports:
eslint-disable/eslint-enableeslint-disable-lineeslint-disable-next-lineWhile working on this, I discovered a bug in
no-htmlwhere it was only reporting the first HTML tag in anhtmlnode even though there can be multiple. It was also skipping anyhtmlnode that began with a comment. I also fixed these bugs in this PR, as I needed a good example to test the disable directives.Note: This PR intentionally does not implement inline configuration comments like
/* eslint rule:error */.