Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 Failing tests on project install #592

Closed
martypdx opened this issue Jan 6, 2024 · 1 comment
Closed

9 Failing tests on project install #592

martypdx opened this issue Jan 6, 2024 · 1 comment

Comments

@martypdx
Copy link

martypdx commented Jan 6, 2024

After forking, cloning, npm i, npm test has 9 failures in tests/6/modules and tests/8/modules. They are all import/export related and fail with this error (though different locations):

      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected ... Lines skipped

  {
    body: [
...
          15
        ],
+       type: 'Identifier',
-       type: 'Keyword',
        value: 'default'
...
    ],
    type: 'Program'
  }
      + expected - actual

             "range": [
               8
               15
             ]
      -      "type": "Identifier"
      +      "type": "Keyword"
             "value": "default"

Updating to latest acorn doesn't help.

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 6, 2024
@mdjermanovic
Copy link
Member

We're working on this in #590, looks like a problem in the latest acorn.

@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants