-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up release-please #569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've updated the espree
package's npm settings to allow for CI tokens to publish.
Just waiting for @mdjermanovic as he is determining when to roll out release-please to more packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Milos Djermanovic <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Referencing the checklist from #563, I was still able to complete the first two independently, but one of the TSC members will need to complete the third item:
In setting this up previously on other repositories, some packages already had this setting enabled, so don't be surprised if that's the case.
Fixes #563
To ease review, this differs from https://github.com/eslint/create-config/blob/9fc2de4eb76dd04218b5a4c72a6006563c74f589/.github/workflows/release-please.yml only by the package name: