Update: consecutive option for one-var (fixes #4680) #9994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
aladdin-add
added
enhancement
btmills
reviewed
Mar 2, 2018
There was a problem hiding this comment.
Just a couple minor tweaks, but this looks really good. Nice work @kaicataldo and @aladdin-add!
|
|
||
| ```js | ||
| /*eslint one-var: ["error", "consecutive"]*/ | ||
| /*eslint-env es6*/ |
There was a problem hiding this comment.
The es6 env isn't strictly necessary for this example, though I'm fine keeping it for consistency with all the other examples in this PR.
lib/rules/one-var.js
Outdated
| const declarationCounts = countDeclarations(declarations); | ||
| const mixedRequires = declarations.some(isRequire) && !declarations.every(isRequire); | ||
| if (isPreviousNodeDeclaration && previousNode.kind === type) { | ||
| const previousDeclCounts = previousNode && countDeclarations(previousNode.declarations); |
There was a problem hiding this comment.
Guarding this line with previousNode && looks to be redundant, since lines 307 and 309 above would've thrown if previousNode was falsy.
docs/rules/one-var.md
Outdated
| @@ -36,23 +36,29 @@ String option: | |||
|
|
|||
| * `"always"` (default) requires one variable declaration per scope | |||
| * `"never"` requires multiple variable declarations per scope | |||
| * `"consecutive"` allows multiple variable declarations per scope but requires consecutive variables declarations to be combined into a single declaration | |||
There was a problem hiding this comment.
Nit: "consecutive variables variable declarations"
ilyavolodin
approved these changes
Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 16, 2018
This was referenced Mar 22, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Changes an existing rule (template)
What changes did you make? (Give an overview)
fixes #4680
Is there anything you'd like reviewers to focus on?