Fix: support Rest/Spread Properties (fixes #9885) #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
commented
Feb 5, 2018
| property.shorthand || | ||
| property.kind !== "init" || property.type !== "Property") // Could be "ExperimentalSpreadProperty" or "SpreadProperty" | ||
| property.kind !== "init" || | ||
| property.type !== "Property" // Could be "ExperimentalSpreadProperty" or "SpreadElement" |
There was a problem hiding this comment.
This is trivial; I just removed extra parens.
mysticatea
commented
Feb 5, 2018
| @@ -524,7 +596,7 @@ ruleTester.run("key-spacing", rule, { | |||
| beforeColon: true, | |||
| afterColon: false | |||
| }], | |||
| parserOptions: { ecmaVersion: 6, ecmaFeatures: { experimentalObjectRestSpread: true } } | |||
| parserOptions: { ecmaVersion: 6 } | |||
There was a problem hiding this comment.
Removing such as this in this file is trivial; those were unused.
platinumazure
approved these changes
Feb 5, 2018
ljharb
approved these changes
Feb 5, 2018
ilyavolodin
approved these changes
Feb 6, 2018
|
@ljharb I'll check it. |
|
It's no problem. I added test cases. |
|
Thanks for contributing! |
This was referenced Mar 8, 2018
This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Fixes #9885.
What changes did you make? (Give an overview)
This PR focuses on "rules work fine if people replace
experimentalObjectRestSpread: truetoecmaVersion: 2018". I cloned all tests which haveexperimentalObjectRestSpread: trueoption, then rewrote it toecmaVersion: 2018.I updated the tests of 14 rules, then I fixed 4 rules (
no-self-assign,no-unused-vars,object-shorthand, andrest-spread-spacing).Is there anything you'd like reviewers to focus on?
Nothing in particular.