Update: support separate requires in one-var. (fixes #6175) #9441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
aladdin-add
added
accepted
aladdin-add
force-pushed
the
issue6175
branch
3 times, most recently
from
a020a67 to
2fde846
Compare
aladdin-add
force-pushed
the
issue6175
branch
from
2fde846 to
7d97579
Compare
aladdin-add
changed the title
aladdin-add
commented
Nov 14, 2017
| options.var = { uninitialized: mode.var, initialized: mode.var }; | ||
| } | ||
| if (mode.hasOwnProperty("let") && typeof mode.let === "string") { |
There was a problem hiding this comment.
removed checking type, since ajv would have checked.
ljharb
reviewed
Nov 14, 2017
aladdin-add
force-pushed
the
issue6175
branch
from
da28611 to
36704fb
Compare
aladdin-add
force-pushed
the
issue6175
branch
from
36704fb to
c8fd8ea
Compare
ilyavolodin
approved these changes
Dec 23, 2017
not-an-aardvark
approved these changes
Dec 23, 2017
This was referenced Mar 8, 2018
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Changes an existing rule (template)
What changes did you make? (Give an overview)
fixes #6175
Is there anything you'd like reviewers to focus on?