Update: Add Fixer method to Linter API #8631

gyandeeps · 2017-05-21T19:33:28Z

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ x ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Moved fixer code from CLIEngine to Linter API. This way it can be consumed on the web also.
Issue link: eslint/archive-website#322

Is there anything you'd like reviewers to focus on?

I named the function verifyAndFix based on verify method. Any other name suggestions?

If accepted:

Docs

not-an-aardvark

This looks good to me, I just have a few suggestions.

not-an-aardvark · 2017-05-21T19:57:09Z

lib/linter.js

-    pkg = require("../package.json");
-
+const debug = require("debug")("eslint:linter");
+const MAX_PASSES = 10;


Can you rename this variable to something like MAX_AUTOFIX_PASSES? It's not clear what the variable is referring to when it's not in the autofix function.

not-an-aardvark · 2017-05-21T20:01:35Z

lib/cli-engine.js

@@ -269,7 +193,7 @@ function processText(text, configHelper, filename, fix, allowInlineConfig, linte
    } else {

        if (fix) {
-            fixedResult = multipassFix(text, config, {
+            fixedResult = linter.verifyAndFix(text, config, {
                filename,
                allowInlineConfig
            }, linter);


The linter argument is no longer necessary here.

kaicataldo · 2017-05-24T21:38:41Z

It sounds like @nzakas was against this change in this comment - have things changed since that last discussion?

kaicataldo · 2017-05-24T21:38:57Z

Sorry! Clicked the wrong button!

gyandeeps · 2017-05-24T21:42:56Z

I think he was against moving it into linter API exposed on api.js. Now we have designed a Linter class and exposed on API, which essentially is kinda WebView that why i thought of moving this in here.

What this does is that Linter can verify the code and also fix the code and return the fixed code. Now writing out to files n all is still outside Linter (currently handled by CLIEngine).

Personally I dont see any downside of this (unless if i am missing something). Any suggestions?

kaicataldo · 2017-05-24T21:43:43Z

Makes sense :) Thanks for the explanation

not-an-aardvark · 2017-05-24T21:44:10Z

I think the functionality fits into linter better than it fits into CLIEngine anyway, given that it relates to linting text and not CLI-specific behavior.

kaicataldo · 2017-05-24T21:44:24Z

I agree!

ilyavolodin · 2017-05-25T22:14:09Z

@nzakas was originally against moving it into linter, but I never agreed with that position. In my mind CLI deals with user input and file system. Everything else should not be in CLI. So I'm very much 👍 for this change.

gyandeeps · 2017-05-26T15:05:29Z

@kaicataldo @not-an-aardvark @platinumazure @kaicataldo and me (total 5) are all in favor of this. Do we still need to talk in TSC or we can mark it accepted here.
I know we have done this in past and kept TSC meeting for issue which doesn't have a clear path.

platinumazure · 2017-05-26T15:18:59Z

I don't really count since I'm not on TSC. :-)

…

On May 26, 2017 10:05 AM, "Gyandeep Singh" ***@***.***> wrote: @kaicataldo <https://github.com/kaicataldo> @not-an-aardvark <https://github.com/not-an-aardvark> @platinumazure <https://github.com/platinumazure> @kaicataldo <https://github.com/kaicataldo> and me (total 5) are all in favor of this. Do we still need to talk in TSC or we can mark it accepted here. I know we have done this in past and kept TSC meeting for issue which doesn't have a clear path. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8631 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWejppuiPBWDVG3JzCYAtHQqmkNgQ2ks5r9uo6gaJpZM4Nhsk1> .

kaicataldo · 2017-05-26T16:52:55Z

I don't think I count as two votes 😛 I only added the tsc agenda label because it was a change to core. If we have a majority of TSC members who are 👍 for the change I don't think we need to necessarily discuss (though I can see the argument being made that we should always vote on it formally to ensure that everyone sees the issue).

btmills · 2017-06-01T20:22:18Z

This proposal was discussed and accepted in the 2017-06-01 TSC meeting 🎉

not-an-aardvark · 2017-06-02T20:16:48Z

docs/developer-guide/nodejs-api.md

+### verifyAndFix()
+
+This method is similar to `verify` method when it comes to verifying the code against the rules but it also runs the fixer logic from all the fix compatible rules and return the object which has the fixed source code in it.
+The lifecycle is that it verifies the code and then runs the fix on it and this is done at most 10 times right now.


I don't think it's necessary to mention the number of passes here, because it's an implementation detail and could change without warning in the future.

We might also want to explain what messages appear (for example, problems that were fixed will not be reported).

Maybe this paragraph could be reworded:

This method is similar to verify except that it also runs autofixing logic, similar to the --fix flag on the command line. The result object will contain the autofixed code, along with any remaining linting messages for the code that were not autofixed.

kaicataldo

Nice work! I know the behavior here is tested in the lib/cli-engine tests, but do you think it's worth adding some unit tests for lib/linter?

gyandeeps · 2017-06-07T20:36:28Z

Most of the tests are present elsewhere but I have added a test to make sure the API stays intact.

1817: Update eslint to the latest version 🚀 r=jniles ## Version **4.1.0** of [eslint](https://github.com/eslint/eslint) just got published. <table> <tr> <th align=left> Dependency </td> <td> eslint </td> </tr> <tr> <th align=left> Current Version </td> <td> 3.19.0 </td> </tr> <tr> <th align=left> Type </td> <td> devDependency </td> </tr> </table> The version **4.1.0** is **not covered** by your **current version range**. Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though. I recommend you look into these changes and try to get onto the latest version of eslint. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> <strong>v4.1.0</strong> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e8f1362ab640c883a5d296e951308fab22073e7f" class="commit-link"><tt>e8f1362</tt></a> Docs: Remove wrong descriptions in <code>padded-block</code> rule (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8783" class="issue-link js-issue-link" data-url="eslint/eslint#8783" data-id="237771100" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8783</a>) (Plusb Preco)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/291a78302c1d5d402c6582b3f4cc836e61fde787" class="commit-link"><tt>291a783</tt></a> Update: <code>enforceForArrowConditionals</code> to <code>no-extra-parens</code> (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/6196" class="issue-link js-issue-link" data-url="eslint/eslint#6196" data-id="155067290" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#6196</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8439" class="issue-link js-issue-link" data-url="eslint/eslint#8439" data-id="220697521" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8439</a>) (Evilebot Tnawi)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a21dd32c46f95bc232a67929c224824692f94b70" class="commit-link"><tt>a21dd32</tt></a> New: Add <code>overrides</code>/<code>files</code> options for glob-based config (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/3611" class="issue-link js-issue-link" data-url="eslint/eslint#3611" data-id="104053558" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#3611</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8081" class="issue-link js-issue-link" data-url="eslint/eslint#8081" data-id="207675247" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8081</a>) (Sylvan Mably)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/879688ce96f80aa0692f732759c6f67a0c36c4c3" class="commit-link"><tt>879688c</tt></a> Update: Add ignoreComments option to no-trailing-spaces (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8061" class="issue-link js-issue-link" data-url="eslint/eslint#8061" data-id="206865549" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8061</a>) (Jake Roussel)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b58ae2e6d6bd4662b549ca5c0472943055a74df8" class="commit-link"><tt>b58ae2e</tt></a> Chore: Only instantiate fileEntryCache when cache flage set (perf) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8763" class="issue-link js-issue-link" data-url="eslint/eslint#8763" data-id="236756225" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8763</a>) (Gyandeep Singh)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/98512881f1fc2417011247931fa089d987ee8cc6" class="commit-link"><tt>9851288</tt></a> Update: fix indent errors on multiline destructure (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8729" class="issue-link js-issue-link" data-url="eslint/eslint#8729" data-id="235733166" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8729</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8756" class="issue-link js-issue-link" data-url="eslint/eslint#8756" data-id="236673913" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8756</a>) (Victor Hom)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3608f06c2a412587c2d05dec0297803b25f3e630" class="commit-link"><tt>3608f06</tt></a> Docs: Increase visibility of code of conduct (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8758" class="issue-link js-issue-link" data-url="eslint/eslint#8758" data-id="236687424" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8758</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8764" class="issue-link js-issue-link" data-url="eslint/eslint#8764" data-id="236758243" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8764</a>) (Kai Cataldo)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/673a58bc8420075ba698cee6762e17322a5263c3" class="commit-link"><tt>673a58b</tt></a> Update: support multiple fixes in a report (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/7348" class="issue-link js-issue-link" data-url="eslint/eslint#7348" data-id="182620143" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#7348</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8101" class="issue-link js-issue-link" data-url="eslint/eslint#8101" data-id="208681921" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8101</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7a1bc3893ab55d0ab16ccf4b7a62c85329ab4007" class="commit-link"><tt>7a1bc38</tt></a> Fix: don't pass default parserOptions to custom parsers (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8744" class="issue-link js-issue-link" data-url="eslint/eslint#8744" data-id="236336414" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8744</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8745" class="issue-link js-issue-link" data-url="eslint/eslint#8745" data-id="236373829" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8745</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c5b405280409698d14b62cbf3c87b7cf6cf71391" class="commit-link"><tt>c5b4052</tt></a> Chore: enable computed-property-spacing on ESLint codebase (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8760" class="issue-link js-issue-link" data-url="eslint/eslint#8760" data-id="236699991" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8760</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3419f6446e205d79d9db77f6c176b9167d1fd8a7" class="commit-link"><tt>3419f64</tt></a> Docs: describe how to use formatters on the formatter demo page (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8754" class="issue-link js-issue-link" data-url="eslint/eslint#8754" data-id="236645523" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8754</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a3ff8f21106cf8eca55978d4b3e053973f5e1bf2" class="commit-link"><tt>a3ff8f2</tt></a> Chore: combine tests in tests/lib/eslint.js and tests/lib/linter.js (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8746" class="issue-link js-issue-link" data-url="eslint/eslint#8746" data-id="236375849" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8746</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b7cc1e6fe995d52e581fcb2b1a44e37a18680e90" class="commit-link"><tt>b7cc1e6</tt></a> Fix: Space-infix-ops should ignore type annotations in TypeScript (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8341" class="issue-link js-issue-link" data-url="eslint/eslint#8341" data-id="217102387" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8341</a>) (Reyad Attiyat)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/46e73eea69abc2ba80bb1397c6779b8789dbd385" class="commit-link"><tt>46e73ee</tt></a> Fix: eslint --init installs wrong dependencies of popular styles (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/7338" class="issue-link js-issue-link" data-url="eslint/eslint#7338" data-id="182134634" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#7338</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8713" class="issue-link js-issue-link" data-url="eslint/eslint#8713" data-id="235217725" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8713</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a82361b65699653761436a2e9acc7f485c827ca0" class="commit-link"><tt>a82361b</tt></a> Chore: Prevent package-lock.json files from being created (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8742" class="issue-link js-issue-link" data-url="eslint/eslint#8742" data-id="236292937" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8742</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8747" class="issue-link js-issue-link" data-url="eslint/eslint#8747" data-id="236397701" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8747</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f81a68a3904a559764872e3f0c7453865a6c6dc" class="commit-link"><tt>5f81a68</tt></a> New: Add eslintIgnore support to package.json (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8458" class="issue-link js-issue-link" data-url="eslint/eslint#8458" data-id="221689525" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8458</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8690" class="issue-link js-issue-link" data-url="eslint/eslint#8690" data-id="233757916" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8690</a>) (Victor Hom)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b5a70b4e8c20dc1ea3e31137706fc20da339f379" class="commit-link"><tt>b5a70b4</tt></a> Update: fix multiline binary operator/parentheses indentation (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8719" class="issue-link js-issue-link" data-url="eslint/eslint#8719" data-id="235421314" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8719</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8b0167bdaf3b8851eab3fbc2769f2bdd71677b" class="commit-link"><tt>ab8b016</tt></a> Update: fix MemberExpression indentation with "off" option (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8721" class="issue-link js-issue-link" data-url="eslint/eslint#8721" data-id="235434741" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8721</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8724" class="issue-link js-issue-link" data-url="eslint/eslint#8724" data-id="235459105" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8724</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/eb5d12c15a32084907f1c58bcbec721b5008495d" class="commit-link"><tt>eb5d12c</tt></a> Update: Add Fixer method to Linter API (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8631" class="issue-link js-issue-link" data-url="eslint/eslint#8631" data-id="230242473" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8631</a>) (Gyandeep Singh)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/26a2daab311c8c59942c52f436d380a195db2bd4" class="commit-link"><tt>26a2daa</tt></a> Chore: Cache fs reads in ignored-paths (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8363" class="issue-link js-issue-link" data-url="eslint/eslint#8363" data-id="218136776" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8363</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8706" class="issue-link js-issue-link" data-url="eslint/eslint#8706" data-id="235004396" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8706</a>) (Victor Hom)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 141 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7d9e3beeb58c1ee71d53dfcfd3e3b0721dd79b46"><code>7d9e3be</code></a> <code>4.1.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e727b7bdfcfb0564aabd713b32364e6f4afcfeec"><code>e727b7b</code></a> <code>Build: changelog update for 4.1.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e8f1362ab640c883a5d296e951308fab22073e7f"><code>e8f1362</code></a> <code>Docs: Remove wrong descriptions in <code>padded-block</code> rule (#8783)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/291a78302c1d5d402c6582b3f4cc836e61fde787"><code>291a783</code></a> <code>Update: <code>enforceForArrowConditionals</code> to <code>no-extra-parens</code> (fixes #6196) (#8439)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a21dd32c46f95bc232a67929c224824692f94b70"><code>a21dd32</code></a> <code>New: Add <code>overrides</code>/<code>files</code> options for glob-based config (fixes #3611) (#8081)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/879688ce96f80aa0692f732759c6f67a0c36c4c3"><code>879688c</code></a> <code>Update: Add ignoreComments option to no-trailing-spaces (#8061)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b58ae2e6d6bd4662b549ca5c0472943055a74df8"><code>b58ae2e</code></a> <code>Chore: Only instantiate fileEntryCache when cache flage set (perf) (#8763)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/98512881f1fc2417011247931fa089d987ee8cc6"><code>9851288</code></a> <code>Update: fix indent errors on multiline destructure (fixes #8729) (#8756)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3608f06c2a412587c2d05dec0297803b25f3e630"><code>3608f06</code></a> <code>Docs: Increase visibility of code of conduct (fixes #8758) (#8764)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/673a58bc8420075ba698cee6762e17322a5263c3"><code>673a58b</code></a> <code>Update: support multiple fixes in a report (fixes #7348) (#8101)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7a1bc3893ab55d0ab16ccf4b7a62c85329ab4007"><code>7a1bc38</code></a> <code>Fix: don't pass default parserOptions to custom parsers (fixes #8744) (#8745)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c5b405280409698d14b62cbf3c87b7cf6cf71391"><code>c5b4052</code></a> <code>Chore: enable computed-property-spacing on ESLint codebase (#8760)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3419f6446e205d79d9db77f6c176b9167d1fd8a7"><code>3419f64</code></a> <code>Docs: describe how to use formatters on the formatter demo page (#8754)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a3ff8f21106cf8eca55978d4b3e053973f5e1bf2"><code>a3ff8f2</code></a> <code>Chore: combine tests in tests/lib/eslint.js and tests/lib/linter.js (#8746)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b7cc1e6fe995d52e581fcb2b1a44e37a18680e90"><code>b7cc1e6</code></a> <code>Fix: Space-infix-ops should ignore type annotations in TypeScript (#8341)</code></li> </ul> <p>There are 141 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/421aab44a9c167c82210bed52f68cf990b7edbea...7d9e3beeb58c1ee71d53dfcfd3e3b0721dd79b46">full diff</a></p> </details> <details> <summary>Not sure how things should work exactly?</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) Bot 🌴

gyandeeps added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 21, 2017

not-an-aardvark reviewed May 21, 2017

View reviewed changes

gyandeeps force-pushed the fixer-move branch from ec37cb3 to 723fdc6 Compare May 21, 2017 20:12

gyandeeps mentioned this pull request May 22, 2017

Can we show auto-fix results in the demo? eslint/archive-website#322

Closed

kaicataldo closed this May 24, 2017

kaicataldo reopened this May 24, 2017

kaicataldo added the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label May 24, 2017

Update: Add Fixer method to Linter API

5dbacb2

gyandeeps force-pushed the fixer-move branch from 723fdc6 to 5dbacb2 Compare June 1, 2017 21:58

not-an-aardvark reviewed Jun 2, 2017

View reviewed changes

fix wording in doc

0a38c72

ilyavolodin approved these changes Jun 4, 2017

View reviewed changes

kaicataldo reviewed Jun 6, 2017

View reviewed changes

add a test for linter's verifyAndFix method

c5e3889

not-an-aardvark approved these changes Jun 8, 2017

View reviewed changes

kaicataldo approved these changes Jun 8, 2017

View reviewed changes

gyandeeps merged commit eb5d12c into master Jun 15, 2017

gyandeeps deleted the fixer-move branch June 15, 2017 01:17

renovate bot mentioned this pull request Jun 24, 2017

Update dependency eslint to version 4.x homezen/hz-test-helpers#42

Merged

renovate-bot mentioned this pull request Jun 24, 2017

Renovate eslint packages singapore/lint-condo#308

Merged

This was referenced Jun 24, 2017

Update dependency eslint to version 4.1.0 renovatebot/renovate#341

Merged

Update dependency eslint to version 4.x xDae/styled-bootstrap#54

Closed

chore(deps): Update dependency eslint to version 4.x renovatebot/renovate#396

Merged

This was referenced Jul 7, 2017

Update dependency eslint to version 4.x algolia/react-element-to-jsx-string#94

Closed

chore(deps): update eslint to v4.x luftywiranda13/generator-bunny#161

Closed

chore(deps): update eslint to v4.x luftywiranda13/generator-bunny#162

Closed

eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018

eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update: Add Fixer method to Linter API #8631

Update: Add Fixer method to Linter API #8631

gyandeeps commented May 21, 2017 •

edited

Loading

not-an-aardvark left a comment

not-an-aardvark May 21, 2017

not-an-aardvark May 21, 2017

kaicataldo commented May 24, 2017

kaicataldo commented May 24, 2017

gyandeeps commented May 24, 2017 •

edited

Loading

kaicataldo commented May 24, 2017

not-an-aardvark commented May 24, 2017

kaicataldo commented May 24, 2017

ilyavolodin commented May 25, 2017

gyandeeps commented May 26, 2017

platinumazure commented May 26, 2017 via email

kaicataldo commented May 26, 2017 •

edited

Loading

btmills commented Jun 1, 2017

not-an-aardvark Jun 2, 2017

kaicataldo left a comment

gyandeeps commented Jun 7, 2017

Update: Add Fixer method to Linter API #8631

Update: Add Fixer method to Linter API #8631

Conversation

gyandeeps commented May 21, 2017 • edited Loading

not-an-aardvark left a comment

Choose a reason for hiding this comment

not-an-aardvark May 21, 2017

Choose a reason for hiding this comment

not-an-aardvark May 21, 2017

Choose a reason for hiding this comment

kaicataldo commented May 24, 2017

kaicataldo commented May 24, 2017

gyandeeps commented May 24, 2017 • edited Loading

kaicataldo commented May 24, 2017

not-an-aardvark commented May 24, 2017

kaicataldo commented May 24, 2017

ilyavolodin commented May 25, 2017

gyandeeps commented May 26, 2017

platinumazure commented May 26, 2017 via email

kaicataldo commented May 26, 2017 • edited Loading

btmills commented Jun 1, 2017

not-an-aardvark Jun 2, 2017

Choose a reason for hiding this comment

kaicataldo left a comment

Choose a reason for hiding this comment

gyandeeps commented Jun 7, 2017

gyandeeps commented May 21, 2017 •

edited

Loading

gyandeeps commented May 24, 2017 •

edited

Loading

kaicataldo commented May 26, 2017 •

edited

Loading