Update: Add NewExpression support to comma-style (#9591)

eslint · Jan 20, 2018 · af043eb · af043eb
1 parent 4f898c7
commit af043eb
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 1 deletion.
diff --git a/docs/rules/comma-style.md b/docs/rules/comma-style.md
@@ -37,6 +37,7 @@ This rule also accepts an additional `exceptions` object:
     * `"ObjectExpression": true` ignores comma style in object literals
     * `"ObjectPattern": true` ignores comma style in object patterns of destructuring
     * `"VariableDeclaration": true` ignores comma style in variable declarations
+    * `"NewExpression": true` ignores comma style in the parameters of constructor expressions
 
 A way to determine the node types as defined by [ESTree](https://github.com/estree/estree) is to use the [online demo](https://eslint.org/parser).
 

diff --git a/lib/rules/comma-style.js b/lib/rules/comma-style.js
@@ -49,7 +49,8 @@ module.exports = {
             FunctionDeclaration: true,
             FunctionExpression: true,
             ImportDeclaration: true,
-            ObjectPattern: true
+            ObjectPattern: true,
+            NewExpression: true
         };
 
         if (context.options.length === 2 && context.options[1].hasOwnProperty("exceptions")) {
@@ -294,6 +295,11 @@ module.exports = {
                 validateComma(node, "specifiers");
             };
         }
+        if (!exceptions.NewExpression) {
+            nodes.NewExpression = function(node) {
+                validateComma(node, "arguments");
+            };
+        }
 
         return nodes;
     }

diff --git a/tests/lib/rules/comma-style.js b/tests/lib/rules/comma-style.js
@@ -40,6 +40,7 @@ ruleTester.run("comma-style", rule, {
         "var foo = [\n(bar),\nbaz\n];",
         "var foo = [\n(bar\n),\nbaz\n];",
         "var foo = [\n(\nbar\n),\nbaz\n];",
+        "new Foo(a\n,b);",
         { code: "var foo = [\n(bar\n)\n,baz\n];", options: ["first"] },
         "var foo = \n1, \nbar = [1,\n2,\n3]",
         { code: "var foo = ['apples'\n,'oranges'];", options: ["first"] },
@@ -49,6 +50,7 @@ ruleTester.run("comma-style", rule, {
         { code: "var foo = [1 \n ,2 \n, 3];", options: ["first"] },
         { code: "function foo(){return {'a': 1\n,'b': 2}}", options: ["first"] },
         { code: "function foo(){var a=[1\n, 2]}", options: ["first"] },
+        { code: "new Foo(a,\nb);", options: ["first"] },
         "f(1\n, 2);",
         "function foo(a\n, b) { return a + b; }",
         {
@@ -129,6 +131,14 @@ ruleTester.run("comma-style", rule, {
                 ecmaVersion: 6
             }
         },
+        {
+            code: "new Foo(a,\nb);",
+            options: ["first", {
+                exceptions: {
+                    NewExpression: true
+                }
+            }]
+        },
         {
             code: "f(1\n, 2);",
             options: ["last", {
@@ -211,6 +221,22 @@ ruleTester.run("comma-style", rule, {
             parserOptions: {
                 ecmaVersion: 6
             }
+        },
+        {
+            code: "new Foo(a,\nb);",
+            options: ["last", {
+                exceptions: {
+                    NewExpression: false
+                }
+            }]
+        },
+        {
+            code: "new Foo(a\n,b);",
+            options: ["last", {
+                exceptions: {
+                    NewExpression: true
+                }
+            }]
         }
     ],
 
@@ -255,6 +281,16 @@ ruleTester.run("comma-style", rule, {
                 type: "VariableDeclarator"
             }]
         },
+        {
+            code: "new Foo(a\n,\nb);",
+            output: "new Foo(a,\nb);",
+            options: ["last", {
+                exceptions: {
+                    NewExpression: false
+                }
+            }],
+            errors: [{ message: BAD_LN_BRK_MSG }]
+        },
         {
             code: "var foo = 1\n,bar = 2;",
             output: "var foo = 1,\nbar = 2;",
@@ -543,6 +579,16 @@ ruleTester.run("comma-style", rule, {
                 type: "Property"
             }]
         },
+        {
+            code: "new Foo(a,\nb);",
+            output: "new Foo(a\n,b);",
+            options: ["first", {
+                exceptions: {
+                    NewExpression: false
+                }
+            }],
+            errors: [{ message: FIRST_MSG }]
+        },
         {
             code: "var foo = [\n(bar\n)\n,\nbaz\n];",
             output: "var foo = [\n(bar\n),\nbaz\n];",
@@ -555,6 +601,16 @@ ruleTester.run("comma-style", rule, {
             code: "[(foo),\n,\nbar]",
             output: "[(foo),,\nbar]",
             errors: [{ message: BAD_LN_BRK_MSG }]
+        },
+        {
+            code: "new Foo(a\n,b);",
+            output: "new Foo(a,\nb);",
+            options: ["last", {
+                exceptions: {
+                    NewExpression: false
+                }
+            }],
+            errors: [{ message: LAST_MSG }]
         }
     ]
 });