Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function-paren-newline): add support for Import Attributes #585

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Oct 30, 2024

Description

This PR modifies the function-paren-newline rule to add support for import attributes.

Linked Issues

#578

Additional context

The type annotation on ImportExpression#options seems to be missing.
typescript-eslint/typescript-eslint#10236

Done

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (2015893) to head (09a0ca9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files         121      121           
  Lines       20050    20050           
  Branches     4751     4751           
=======================================
  Hits        19429    19429           
  Misses        618      618           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ota-meshi ota-meshi marked this pull request as ready for review November 5, 2024 00:03
@antfu antfu added this pull request to the merge queue Nov 19, 2024
Merged via the queue into eslint-stylistic:main with commit 4ede153 Nov 19, 2024
11 checks passed
@ota-meshi ota-meshi deleted the function-paren-newline branch November 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants