feat(getStaticValue): Dereference variables that are effectively const
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
changed the title
constconst in getStaticValue
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 96.93% 96.97% +0.03%
==========================================
Files 13 13
Lines 2090 2114 +24
Branches 388 396 +8
==========================================
+ Hits 2026 2050 +24
Misses 63 63
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ota-meshi
reviewed
Mar 20, 2023
ota-meshi
changed the title
const in getStaticValueconst
MichaelDeBoey
force-pushed
the
effectively-const
branch
from
f29e425
to
ff1bfbe
Compare
ota-meshi
approved these changes
Mar 24, 2023
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getStaticValuedereferencesconstvariables. This restriction is necessary as the static execution model would have to be a lot more complex to account for variable mutation. However, this means that it's also fine to deferencevarandletvariables that are never re-assigned (directly viafoo = vaueor indirectly via e.g.foo++).This PR allows referencing all variables that aren't re-assigned (= effectively
const).