From f368c5a7e4a1c1f40cafbf038b629e6054d2027e Mon Sep 17 00:00:00 2001
From: Brett Zamir <brettz9@yahoo.com>
Date: Mon, 22 Jul 2024 07:51:38 +0800
Subject: [PATCH] fix(`always-return`): treat process.exit() or process.abort()
 as an acceptable "return" (#493)

---
 __tests__/always-return.js | 8 ++++++++
 rules/always-return.js     | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/__tests__/always-return.js b/__tests__/always-return.js
index f9411f19..cb888fd6 100644
--- a/__tests__/always-return.js
+++ b/__tests__/always-return.js
@@ -17,6 +17,8 @@ ruleTester.run('always-return', rule, {
     'hey.then(x => { return; })',
     'hey.then(x => { return x ? x.id : null })',
     'hey.then(x => { return x * 10 })',
+    'hey.then(x => { process.exit(0); })',
+    'hey.then(x => { process.abort(); })',
     'hey.then(function() { return 42; })',
     'hey.then(function() { return new Promise(); })',
     'hey.then(function() { return "x"; }).then(doSomethingWicked)',
@@ -24,6 +26,8 @@ ruleTester.run('always-return', rule, {
     'hey.then(function() { throw new Error("msg"); })',
     'hey.then(function(x) { if (!x) { throw new Error("no x"); } return x; })',
     'hey.then(function(x) { if (x) { return x; } throw new Error("no x"); })',
+    'hey.then(function(x) { if (x) { process.exit(0); } throw new Error("no x"); })',
+    'hey.then(function(x) { if (x) { process.abort(); } throw new Error("no x"); })',
     'hey.then(x => { throw new Error("msg"); })',
     'hey.then(x => { if (!x) { throw new Error("no x"); } return x; })',
     'hey.then(x => { if (x) { return x; } throw new Error("no x"); })',
@@ -140,6 +144,10 @@ ruleTester.run('always-return', rule, {
       code: 'hey.then(function() { if (x) { } else { return x; }})',
       errors: [{ message }],
     },
+    {
+      code: 'hey.then(function() { if (x) { process.chdir(); } else { return x; }})',
+      errors: [{ message }],
+    },
     {
       code: 'hey.then(function() { if (x) { return you.then(function() { return x; }); } })',
       errors: [{ message }],
diff --git a/rules/always-return.js b/rules/always-return.js
index 57d497d0..be74b5c2 100644
--- a/rules/always-return.js
+++ b/rules/always-return.js
@@ -202,6 +202,10 @@ module.exports = {
     return {
       'ReturnStatement:exit': markCurrentBranchAsGood,
       'ThrowStatement:exit': markCurrentBranchAsGood,
+      'ExpressionStatement > CallExpression > MemberExpression[object.name="process"][property.name="exit"]:exit':
+        markCurrentBranchAsGood,
+      'ExpressionStatement > CallExpression > MemberExpression[object.name="process"][property.name="abort"]:exit':
+        markCurrentBranchAsGood,
 
       /**
        * @param {CodePathSegment} segment