feat(no-unsupported): Support node 23.0.0 and 22.10.0 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
commented
Oct 17, 2024
lib/unsupported-features/node-builtins-modules/worker_threads.js
Outdated
Show resolved
Hide resolved
| SubtleCrypto: { [READ]: { experimental: ["17.6.0", "16.15.0"] } }, | ||
|
|
||
| // module.events | ||
| CustomEvent: events.CustomEvent, | ||
| CloseEvent: { [READ]: { supported: ["23.0.0"] } }, | ||
| CustomEvent: {[READ]: { experimental: ["18.7.0", "16.17.0"], supported: ["23.0.0"] } }, |
There was a problem hiding this comment.
Global CustomEvent differs from node:event's CustomEvent
There was a problem hiding this comment.
🤯 I mostly look at the global docs page, that could be annoying...
I wonder if we should ask someone from Node themselves?
There was a problem hiding this comment.
Indeed annoying, but that's what the docs are saying. 🤷♂️
I think we should always stick to what the docs are saying.
I do think it would be a good idea to have a discussion with people on the Node team to find out if docs are incorrect and if so, update the docs (and our code).
There was a problem hiding this comment.
I see thanks for the explanation here 🙇: #358 (comment)
MichaelDeBoey
force-pushed
the
add-support-for-node-22_10-23_0
branch
from
e2d546c to
9b5f2ec
Compare
scagood
reviewed
Oct 18, 2024
scagood
reviewed
Oct 18, 2024
MichaelDeBoey
force-pushed
the
add-support-for-node-22_10-23_0
branch
from
9b5f2ec to
50f95c2
Compare
scagood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356
Closes #357