-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update eslint-plugin-eslint-plugin
+ update configs
#23
Conversation
Codecov ReportBase: 97.17% // Head: 97.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## alpha #23 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 39 39
Lines 390 389 -1
==========================================
- Hits 379 378 -1
Misses 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@eslint-community/eslint-tsc @eslint-community/core-team @eslint-community/mysticatea-eslint-plugin Since this plugin is adhering the same semantic versioning policy as ESLint, adding new rules to a plugin would be a breaking change, so this PR would need to be released in a major release I guess? |
I assume you mean adding new rules to configs exported from the plugin. I agree that should be a breaking change. |
@mdjermanovic That's indeed what I meant 👍 @eslint-community/mysticatea-eslint-plugin I decided to make all the current outstanding PRs a breaking change & merge them into an |
e24a0be
to
1046c2b
Compare
1046c2b
to
5a94cbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
BREAKING CHANGE: `+eslint-plugin` config now has extra rules from `eslint-plugin-eslint-plugin`
5a94cbf
to
a17bf3f
Compare
🎉 This PR is included in version 15.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 15.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 15.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Re-submission of mysticatea#41
BREAKING CHANGE:
+eslint-plugin
config now has extra rules fromeslint-plugin-eslint-plugin